RFR: 1588: Bridge messages should not be sent for PRs in draft state [v4]

Guoxiong Li gli at openjdk.org
Tue Feb 14 20:42:58 UTC 2023

On Tue, 14 Feb 2023 14:31:17 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch prevents the `mailling bridge bot` from sending emails when a PR is draft.
>> And the related test case is added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Use max method instead of reduce

It seems a new bug:

When a PR has become ready and then another PR, of which code conflicts with the former one, was integrated, the former PR remains ready. But actually, it should have a `merge-conflict` label and should not be ready.

This PR-1469 (SKARA-1588) has became ready and then PR-1472 (SKARA-1817) was integrated. This PR is still ready now. But actually, this PR should have a `merge-conflict` label and should not be ready (the `ready` label should be removed and the related comment aboud conflict should be added).

I suspect it is because PR bot have not been triggerred in this PR (since this PR has not been updated). This comment can update this PR and can verify my idea.


PR: https://git.openjdk.org/skara/pull/1469

More information about the skara-dev mailing list