RFR: 1821: The 'timeline` API in GitHub doesn't point out the sorting order [v2]

Guoxiong Li gli at openjdk.org
Wed Feb 15 14:35:16 UTC 2023


On Wed, 15 Feb 2023 14:04:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify lambda expression.
>
> forge/src/main/java/org/openjdk/skara/forge/github/GitHubPullRequest.java line 797:
> 
>> 795:                 .filter(obj -> ZonedDateTime.parse(obj.get("created_at").asString()).isAfter(lastMarkedAsReadyTime(timelineJSON)))
>> 796:                 .map(obj -> ZonedDateTime.parse(obj.get("created_at").asString()))
>> 797:                 .max(ZonedDateTime::compareTo);
> 
> Suggestion:
> 
>                 .max(Comparator.naturalOrder());

Fixed.

-------------

PR: https://git.openjdk.org/skara/pull/1473


More information about the skara-dev mailing list