RFR: 1271: Webrev generation should be optional

Zhao Song zsong at openjdk.org
Thu Feb 16 00:09:20 UTC 2023

On Thu, 16 Feb 2023 00:03:32 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, webrevs are generated automatically when a user pushes a new commit, and it's mandatory to choose either JSON or HTML when configuring the mlbridge bot. If both of them are disabled in the configuration, the bot will throw errors.
> In this patch, generating a webrev will be optional. If both JSON and HTML are disabled, no webrev will be generated.

Above `ArchiveMessages#composeConversationFooter`, there is a comment says `// When changing this, ensure that the PR pattern in the notifier still matches`. I tried to figure out where the PR pattern is, but I couldn't find it.


PR: https://git.openjdk.org/skara/pull/1475

More information about the skara-dev mailing list