RFR: 1035: Race when creating backports for bug spanning multiple repos [v2]

Vijay Kulkarni duke at openjdk.org
Thu Feb 16 17:13:27 UTC 2023


On Thu, 16 Feb 2023 14:18:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Vijay Kulkarni has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Caught more specific exception in case of backport fails & updated error message.
>
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 313:
> 
>> 311:                                     existing = Backports.findIssue(issue, fixVersion);
>> 312:                                     if (existing.isPresent()) {
>> 313:                                         log.info("Race condition occurred while creating the back port. So returning an existing backport for " + issue.id() + " and requested fixVersion "
> 
> Suggestion:
> 
>                                         log.info("Race condition occurred while creating backport issue, returning the existing backport for " + issue.id() + " and requested fixVersion "

Sure, did the rewording as suggested, thanks.

-------------

PR: https://git.openjdk.org/skara/pull/1476


More information about the skara-dev mailing list