RFR: 1271: Webrev generation should be optional

[Erik Joelsson]

On Thu, 16 Feb 2023 21:43:49 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java line 332:
>> 
>>> 330:         if (webrevs.size() > 0) {
>>> 331:             if (webrevs.stream().noneMatch(w -> w.uri() != null)) {
>>> 332:                 webrevLinks = "Webrev is disabled\n\n";
>> 
>> I think this should just be `""` or possibly `"\n"`, not sure.
>
> else {
>             webrevLinks = "The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.\n\n";
>         }
> 
> I just tried to align with this.

Yes, I figured that, but there is an important difference. That message explains why there is no webrevs where the user would expect them to be, but for a repo where they are completely turned off, I think we shouldn't even mention them.

-------------

PR: https://git.openjdk.org/skara/pull/1475