RFR: 1271: Webrev generation should be optional

Zhao Song zsong at openjdk.org
Thu Feb 16 22:58:21 UTC 2023


On Thu, 16 Feb 2023 22:36:48 GMT, Zhao Song <zsong at openjdk.org> wrote:

> > Above `ArchiveMessages#composeConversationFooter`, there is a comment says `// When changing this, ensure that the PR pattern in the notifier still matches`. I tried to figure out where the PR pattern is, but I couldn't find it.
> 
> I believe it's the logic that parses email from the email list server and extracts the PR URL from the verify first email in the each thread. You are likely safe here as you aren't changing the line that contains the PR URL, but better be safe.

The logic you mentioned seems like has been deleted in SKARA-386. So I think we are safe.

-------------

PR: https://git.openjdk.org/skara/pull/1475


More information about the skara-dev mailing list