RFR: 1271: Webrev generation should be optional

Zhao Song zsong at openjdk.org
Fri Feb 17 17:20:46 UTC 2023


On Fri, 17 Feb 2023 00:17:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > > I believe it's the logic that parses email from the email list server and extracts the PR URL from the verify first email in the each thread. You are likely safe here as you aren't changing the line that contains the PR URL, but better be safe.
> > 
> > 
> > The logic you mentioned seems like has been deleted in SKARA-386. So I think we are safe.
> 
> The logic I was thinking about is in `MailingListArchiveReaderBot` `PULL_REQUEST_LINK_PATTERN`.

You're right, it was not deleted, just moved.

-------------

PR: https://git.openjdk.org/skara/pull/1475


More information about the skara-dev mailing list