RFR: 1823: Mailing list bot should include link to comment on the Git forge [v4]

Zhao Song zsong at openjdk.org
Tue Feb 21 20:45:56 UTC 2023


On Tue, 21 Feb 2023 20:29:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   trigger workflow
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java line 308:
> 
>> 306:     }
>> 307: 
>> 308:     static String composeReplyFooter(PullRequest pr, Comment comment, ReviewComment reviewComment, Review review) {
> 
> I think you should just split this into 3 separate methods. I can't see any caller that uses more than one of Comment, ReviewComment or Review.

Sure. I will fix it.

-------------

PR: https://git.openjdk.org/skara/pull/1478


More information about the skara-dev mailing list