RFR: 755: Anything starting with a "/" is treated as a command

Kevin Rushforth kcr at openjdk.org
Fri Feb 24 16:04:11 UTC 2023

On Fri, 24 Feb 2023 14:38:34 GMT, Vijay Kulkarni <duke at openjdk.org> wrote:

> 755: Anything starting with a "/" is treated as a command

> I think this change is good and I directed Vijay to tackle this issue.
> It's a difficult tradeoff for sure, but I've seen the command extractor trigger on unintentional command looking comments more often than I would like. Especially the filtering when sending emails is problematic. See for example this PR and corresponding email:
> [openjdk/jdk#12695](https://github.com/openjdk/jdk/pull/12695) https://mail.openjdk.org/pipermail/build-dev/2023-February/037829.html
> I'm not sure why the PR bot didn't reply to that instance though.
> > I might recommend the more targeted solution of not treating `/sometext` as a command when it appears in a code block.
> That would be another approach, but it would require a more complicated parsing logic. I could also imagine adding some kind of fuzzy matcher on the existing commands so that obvious spelling errors were caught. I'm not sure it's worth the effort.

OK, I can see your point. What do you think about also producing a comment with a warning (but not filtering the email) in case there is an unrecognized command with a `/` at the beginning of a line? Something like:

"I see that you entered a comment with `/sometext` at the beginning of a line. `/sometext` is not a recognized Skara PR command, so it was ignored and treated like an ordinary comment. If you intended to issue a Skara command, use `/help` in a comment to see a complete list of Skara commands."


PR: https://git.openjdk.org/skara/pull/1479

More information about the skara-dev mailing list