RFR: GitRepository#revert does not work as intended

Erik Joelsson erikj at openjdk.org
Tue Jan 3 14:23:07 UTC 2023

On Sun, 25 Dec 2022 19:49:01 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> The `Repository#revert` interface is meant to allow for rolling the Repository back to a specific commit, but the Git implementation in `GitRepository#revert` implements this via a checkout, which can cause issues, especially with newer versions of Git where it doesn't have any effect at all. More appropriate would be using `git restore --source` to implement the GitRepository variant instead, which is actually the encouraged way to do so nowadays

This looks correct. It doesn't seem like we are using this call anywhere currently for git repos, so this change shouldn't affect any current functionality.


Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.org/skara/pull/1450

More information about the skara-dev mailing list