RFR: 1663: Mark integrated Pull Requests as properly merged in their repositories [v57]

Julian Waters jwaters at openjdk.org
Thu Jan 5 15:24:04 UTC 2023

On Thu, 5 Jan 2023 14:02:23 GMT, altrisi <duke at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>   Ensure fetch properly advances local branch
> Is there any reason why Skara doesn't use (or emulate in a way that is detected if there's no direct way/endpoint) what GitHub does when using the "Rebase and Merge" button?
> That marks pull requests as merged unless it's changed recently, without making the rebase directly in the PR branch.

@altrisi could you elaborate further on this "Rebase and Merge" feature for GitHub? Do you mean the usual rebasing and merging of the PR's actual sequence of commits directly into the repository, or is this part of GitHub's indirect merge logic (where the Pull Request does not need to be actually merged into the target branch for it to be marked as merged, I am aware that there are a few circumstances where GitHub will currently do that) that I haven't heard of? If it's the latter, I am pretty curious and interested


PR: https://git.openjdk.org/skara/pull/1409

More information about the skara-dev mailing list