RFR: 1729: CSR bot should not remove CSR label if one of the CSR issues is withdrawn [v2]

Zhao Song zsong at openjdk.org
Mon Jan 9 20:15:10 UTC 2023

> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714), I discovered a bug in the PullRequestWorkItem of the CSR bot. 
> Currently, the CSR bot would remove CSR label if all the CSR issues of the pr is closed(whether approved or withdrawn). However, this behavior does not align with the original logic. The correct logic is that if one of the CSR issues is withdrawn, CSR bot should not remove the CSR label automatically. In this case, only reviewer uses '/csr unneeded' command will be able to remove the CSR label.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  changed the logic about removing CSR label when pr contains withdrawn csr issue


  - all: https://git.openjdk.org/skara/pull/1451/files
  - new: https://git.openjdk.org/skara/pull/1451/files/0b99714f..4b9f58f0

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1451&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1451&range=00-01

  Stats: 26 lines in 2 files changed: 19 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/skara/pull/1451.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1451/head:pull/1451

PR: https://git.openjdk.org/skara/pull/1451

More information about the skara-dev mailing list