RFR: 1729: CSR bot should not remove CSR label if one of the CSR issues is withdrawn [v2]

Zhao Song zsong at openjdk.org
Mon Jan 9 22:02:10 UTC 2023


On Mon, 9 Jan 2023 21:43:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed the logic about removing CSR label when pr contains withdrawn csr issue
>
> bots/csr/src/main/java/org/openjdk/skara/bots/csr/PullRequestWorkItem.java line 277:
> 
>> 275:             }
>> 276:         }
>> 277:         return CSRNeededCommentCount > 0;
> 
> I don't think this should be determined by count. The last comment with `` in it is the one that is currently in effect.

Agree with you, I will change it.

-------------

PR: https://git.openjdk.org/skara/pull/1451


More information about the skara-dev mailing list