RFR: 1729: CSR bot should not remove CSR label if one of the CSR issues is withdrawn [v3]

Erik Joelsson erikj at openjdk.org
Mon Jan 9 23:30:49 UTC 2023

On Mon, 9 Jan 2023 22:17:46 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> While testing [SKARA-1714](https://bugs.openjdk.org/browse/SKARA-1714), I discovered a bug in the PullRequestWorkItem of the CSR bot. 
>> Currently, the CSR bot would remove CSR label if all the CSR issues of the pr is closed(whether approved or withdrawn). However, if the CSR label is added via using '/csr needed' command and the pr contains withdrawn CSR issues, the CSR should not remove the CSR label.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   change the logic about the method isCSRNeeded

Marked as reviewed by erikj (Lead).


PR: https://git.openjdk.org/skara/pull/1451

More information about the skara-dev mailing list