Integrated: GitRepository#revert does not work as intended

Julian Waters jwaters at
Tue Jan 10 15:03:58 UTC 2023

On Sun, 25 Dec 2022 19:49:01 GMT, Julian Waters <jwaters at> wrote:

> The `Repository#revert` interface is meant to allow for rolling the Repository back to a specific commit, but the Git implementation in `GitRepository#revert` implements this via a checkout, which can cause issues, especially with newer versions of Git where it doesn't have any effect at all. More appropriate would be using `git restore --source` to implement the GitRepository variant instead, which is actually the encouraged way to do so nowadays

This pull request has now been integrated.

Changeset: d5e6e591
Author:    Julian Waters <jwaters at>
Committer: Erik Joelsson <erikj at>
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

GitRepository#revert does not work as intended

Reviewed-by: erikj



More information about the skara-dev mailing list