RFR: 1737: Draft PR for clean backport mistakenly marked as ready

Zhao Song zsong at openjdk.org
Wed Jan 11 23:54:34 UTC 2023

On Wed, 11 Jan 2023 23:40:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> While this will function correctly, I'm not sure using the contents of newLabels is the right thing to do here. I think it would be better to be explicit and check `pr.isDraft()` directly. It makes it clearer when reading the code what the requirements are. The rest of the requirements for readyForReview are already repeated in the readyForIntegration checks.
> It would also be possible to more clearly define a boolean for `readyForReview` (maybe as a return value from `updateReadyForReview`?) and use that in this check, but then also remove the redundant checks in `readyForIntegration`.

It's a good idea to define a boolean called `readyForReview` and remove the redundant checks. I will do it now. Thanks for the advice!


PR: https://git.openjdk.org/skara/pull/1456

More information about the skara-dev mailing list