RFR: 1727: Ability to control whether clean backports require review

[Erik Joelsson]

On Thu, 12 Jan 2023 21:30:40 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this patch, PR bot has been added with the capability to control the requirement of reviews for clean backports. 
> 
> By default, no review is necessary for clean backports. 
> 
> However, if it is desired to enable the requirement of reviews for backports in a repo, the configuration can be added to the PR bot configuration as follows:
> 
> {
>   "pr": {
>       "repositories": {
>           "repo1": {
>                "requiresReviewForBackport": true
>           }
>        }
>   }
> }

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 72:

> 70:     private final static Set<String> primaryTypes = Set.of("Bug", "New Feature", "Enhancement", "Task", "Sub-task");
> 71:     private final Set<String> newLabels;
> 72:     private final boolean requiresReviewForBackport;

Can we change the name and the configuration option to `reviewCleanBackport`

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 520:

> 518:     }
> 519: 
> 520:     private String getChecksList(PullRequestCheckIssueVisitor visitor, boolean noNeedReview, Map<String, Boolean> additionalProgresses) {

Can we flip this boolean to avoid negation in the name? I would suggest `reviewNeeded`.

-------------

PR: https://git.openjdk.org/skara/pull/1457