RFR: 1727: Ability to control whether clean backports require review [v2]

Erik Joelsson erikj at openjdk.org
Fri Jan 13 21:02:36 UTC 2023


On Fri, 13 Jan 2023 17:20:25 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In this patch, PR bot has been added with the capability to control the requirement of reviews for clean backports. 
>> 
>> By default, no review is necessary for clean backports. 
>> 
>> However, if it is desired to enable the requirement of reviews for backports in a repo, the configuration can be added to the PR bot configuration as follows:
>> 
>> {
>>   "pr": {
>>       "repositories": {
>>           "repo1": {
>>                "requiresReviewForBackport": true
>>           }
>>        }
>>   }
>> }
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   renamed two variables

Marked as reviewed by erikj (Lead).

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1175:

> 1173:                                       integrationBlockers.isEmpty();
> 1174:             if (!reviewNeeded) {
> 1175:                 // Reviews are not needed for clean backports if this repo is not configured with reviewCleanBackport enabled

Suggestion:

                // Reviews are not needed for clean backports unless this repo is configured with reviewCleanBackport enabled

-------------

PR: https://git.openjdk.org/skara/pull/1457


More information about the skara-dev mailing list