RFR: 1173: Dependent PR feature does not work with protected branches in newer Gitlab version [v2]

Erik Joelsson erikj at openjdk.org
Fri Jan 13 21:15:19 UTC 2023

On Fri, 13 Jan 2023 21:07:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHostedRepository.java line 177:
>>> 175:     @Override
>>> 176:     public void protectBranchPattern(String ref) {
>>> 177:     }
>> The name of this method is protectBranchPattern, but I think it actually protects a specific branch rather than a pattern.
> Hm, on GitLab the underlying call takes a pattern, but now that I think about it, on GitHub it doesn't. There you have to use GraphQL to add pattern based protection. I should change this method to reflect that. We aren't using patterns anyway.

I take that back. I see now that I chose not to implement this on GitHub at all since we don't need it. This does take a branch pattern, which are supported by both GitHub and GitLab in the web UI.


PR: https://git.openjdk.org/skara/pull/1452

More information about the skara-dev mailing list