RFR: 1789: Skara PR commands are not interpreted on Github review comments

Erik Joelsson erikj at openjdk.org
Wed Jan 18 19:59:06 UTC 2023

On Wed, 18 Jan 2023 18:04:42 GMT, Zhao Song <zsong at openjdk.org> wrote:

> A user reported that Skara bots were not responding to commands in review comments or the body of a review. 
> This patch addresses that issue by ensuring that the Skara bots can correctly detect and interpret commands.

I will need to think more on what this means and how it would work. The bug only asked for adding commands in `Review`, not `ReviewComment`. I don't think it makes sense to run commands in a `ReviewComment`. (The latter is a comment on a specific file or line inside a review)

If we do this, then commands must still be processed in order, so the list needs to be sorted on create time.

We also need to consider how this applies to Gitlab, where reviews are different.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list