RFR: 1789: Skara PR commands are not interpreted on Github review comments

Zhao Song zsong at openjdk.org
Wed Jan 18 20:07:19 UTC 2023

On Wed, 18 Jan 2023 19:54:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I will need to think more on what this means and how it would work. The bug only asked for adding commands in `Review`, not `ReviewComment`. I don't think it makes sense to run commands in a `ReviewComment`. (The latter is a comment on a specific file or line inside a review)
> If we do this, then commands must still be processed in order, so the list needs to be sorted on create time.
> We also need to consider how this applies to Gitlab, where reviews are different.

In the description of the bug, Magnus said "I guess the same goes if you would make a single comment in review mode as well, but I have not tested this. ". I thought he would expect the command in single comment(which is reviewComment) could be interpreted too. I don't know whether we need it or not.

It's a good point that we should sort the comments by created time. I will fix it now.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list