RFR: 1789: Skara PR commands are not interpreted on Github review comments [v2]

Kevin Rushforth kcr at openjdk.org
Thu Jan 19 12:54:18 UTC 2023

On Thu, 19 Jan 2023 06:42:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I also have misgivings about scanning review comments for PR commands - so it seems there is consensus there.

I definitely agree with David and others on this.

> Even in the main review comment what gets scanned - all the text? Only the start of lines? I would worry about text being misconstrued as a command. This would especially be true for skara PRs where review comments may well refer to PR commands as part of the discussion.

If it works the same as PR commands in ordinary comments, they are only parsed at the beginning of a line after trimming whitespace. @erikj79 or @zhaosongzs can confirm.


PR: https://git.openjdk.org/skara/pull/1458

More information about the skara-dev mailing list