RFR: 1789: Skara PR commands are not interpreted on Github review comments [v2]

[Zhao Song]

On Thu, 19 Jan 2023 15:56:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> Given the discussion around only using "ordinary" PR comments, and not inline comments, I think the "and file specific comments" part is now wrong.

Good catch! Thanks Kevin. Will fix it.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 245:
> 
>> 243: //        comments.addAll(pr.reviewComments().stream()
>> 244: //                .map(reviewComment -> new Comment("ReviewComment" + reviewComment.id(), reviewComment.body(), reviewComment.author(), reviewComment.createdAt(), reviewComment.updatedAt()))
>> 245: //                .toList());
> 
> Since we have decided not to do this, I recommend to remove this commented out code.

Sure

> bots/pr/src/test/java/org/openjdk/skara/bots/pr/PullRequestCommandTests.java line 395:
> 
>> 393: //            // Run the bot
>> 394: //            TestBotRunner.runPeriodicItems(prBot);
>> 395: //            assertLastCommentContains(pr, "The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 4");
> 
> Ditto the recommendation to remove this.

Sure

-------------

PR: https://git.openjdk.org/skara/pull/1458