RFR: 1789: Skara PR commands are not interpreted on Github review comments [v3]
Zhao Song
zsong at openjdk.org
Thu Jan 19 19:54:38 UTC 2023
On Thu, 19 Jan 2023 19:33:26 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove some comments and add tests
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 237:
>
>> 235: private List<Comment> getAllComments() {
>> 236: // Regular comments
>> 237: List<Comment> comments = new ArrayList<>(prComments());
>
> It's not really important, but you could use Streams.concat() instead of creating two intermediate lists.
It would be better
-------------
PR: https://git.openjdk.org/skara/pull/1458
More information about the skara-dev
mailing list