RFR: 1789: Skara PR commands are not interpreted on Github review comments [v2]
David Holmes
dholmes at openjdk.org
Fri Jan 20 02:43:49 UTC 2023
On Thu, 19 Jan 2023 14:42:10 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>
>> sort comments by created time
>
> *LOL*
>
> Thank you @openjdk bot for providing a quick example that the risk for "misconstruing" commands are just as present in normal commands, and not something that will be a special problems for main review comments. :-D
@magicus you demonstrated my concern about misconstrued comments beautifully - thank you :)
If they are only processed as commands at the start of the line that greatly reduces the risk and concern, and for the rest people just have to be careful. :)
-------------
PR: https://git.openjdk.org/skara/pull/1458
More information about the skara-dev
mailing list