RFR: 1725: Clarify "no known role" error message
Magnus Ihse Bursie
ihse at openjdk.org
Mon Jan 23 15:15:43 UTC 2023
On Thu, 19 Jan 2023 22:27:09 GMT, Zhao Song <zsong at openjdk.org> wrote:
> A user reported that when people review PRs, the bot adds a list of reviewers into description. If a user is not registered in OpenJDK Census, a note is added:
>
> (no known github.com user name / role)
>
> What it actually means is "no known OpenJDK user name / role".
>
> Github.com is being used here because we are utilizing the name of the namespace. However, the purpose of the namespace is to map users from this namespace to either openjdk or internal. Actually, we couldn't find the user in openjdk or internal, not in the namespace. The census repository name can indicate whether it is openjdk or internal.
I think "has no OpenJDK user name" is better than "has no openjdk.org user name", so we would need to do something about that if we were to use that field. A "openjdk.org user name" sounds like something you could use on the home page, which is not a thing. The accounts we are talking about are commonly referred to as "OpenJDK user name" and I think we should stay with that terminology.
-------------
PR: https://git.openjdk.org/skara/pull/1459
More information about the skara-dev
mailing list