RFR: 1806: Optimize the CSR progress message and log when CSR not found

Zhao Song zsong at openjdk.org
Thu Jan 26 21:14:36 UTC 2023

On Thu, 26 Jan 2023 20:50:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Yes, the two different Issue types definitely adds to the confusion, but we also have the `::issues` method that takes two booleans. It has three callers and only one of those sets the parameters true. This should just have been split into different methods. As it is now, they are calling each other in a circle, only saved by the boolean being false in the second call. Untangling this would make it pretty straightforward to provide a JdkVersion argument to the method for getting just CSR issues.
> I think there is value in only calling `BotUtils.getVersion(pr)` once as it's quite expensive to evaluate.

Good idea, I will split them into different methods. Thx!


PR: https://git.openjdk.org/skara/pull/1463

More information about the skara-dev mailing list