RFR: 1806: Optimize the CSR progress message and log when CSR not found [v2]

[Erik Joelsson]

On Thu, 26 Jan 2023 22:03:38 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that she have a PR which can't find its corresponding CSR. 
>> Erik found that the issue was caused by the user not updating their branch in a long time, and the fixVersion in the .jcheck/conf file was still set at 20. However, the fixVersion of the CSR was 21, make the bot unable to locate the corresponding CSR. 
>> 
>> In this patch, I optimized the CSR progress message and log.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refactor

This is definitely better. I still feel like the whole class could use some kind of overhaul, but no need to dig further now.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 167:

> 165:      * Get the csr issue. Note: this `Issue` is not the issue in module `issuetracker`.
> 166:      */
> 167:     private List<Issue> getCsrIssues(List<org.openjdk.skara.issuetracker.Issue> CsrIssueTrackerIssues) {

Suggestion:

    private List<Issue> getCsrIssues(List<org.openjdk.skara.issuetracker.Issue> csrIssueTrackerIssues) {

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 169:

> 167:     private List<Issue> getCsrIssues(List<org.openjdk.skara.issuetracker.Issue> CsrIssueTrackerIssues) {
> 168: 
> 169:         return CsrIssueTrackerIssues.stream()

Suggestion:

        return csrIssueTrackerIssues.stream()

-------------

PR: https://git.openjdk.org/skara/pull/1463