RFR: 1806: Optimize the CSR progress message and log when CSR not found [v3]
Erik Joelsson
erikj at openjdk.org
Thu Jan 26 22:40:46 UTC 2023
On Thu, 26 Jan 2023 22:36:51 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> A user reported that she have a PR which can't find its corresponding CSR.
>> Erik found that the issue was caused by the user not updating their branch in a long time, and the fixVersion in the .jcheck/conf file was still set at 20. However, the fixVersion of the CSR was 21, make the bot unable to locate the corresponding CSR.
>>
>> In this patch, I optimized the CSR progress message and log.
>
> Zhao Song has updated the pull request incrementally with three additional commits since the last revision:
>
> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>
> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
>
> Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
> - fix a problem
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1131:
> 1129: version = BotUtils.getVersion(pr).orElse(null);
> 1130: } catch (Exception e) {
> 1131: }
I'm not sure ignoring an exception here is a good idea. In what situation did it throw one?
-------------
PR: https://git.openjdk.org/skara/pull/1463
More information about the skara-dev
mailing list