RFR: 1806: Optimize the CSR progress message and log when CSR not found [v3]

Zhao Song zsong at openjdk.org
Fri Jan 27 00:10:51 UTC 2023

On Thu, 26 Jan 2023 23:49:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> It needs to be solved in some way. Catching `Exception` and ignoring it is not allowed in bot code. That could be triggered by an IOException, or failure in contacting the remote or almost anything else. If that happens, we need to handle the failure correct so that the WorkItem will be retried.
> BotUtils.getVersion either can't throw RuntimeException when it can't find a .jcheck/conf file, or we need to handle the fallback to the override repo. The latter would be cleaner, but we probably don't really need that support. I think returning Optional.empty() from BotUtils.getVersion() is probably ok if no .jcheck/conf file could be found.

Got it! I will fix it


PR: https://git.openjdk.org/skara/pull/1463

More information about the skara-dev mailing list