RFR: 1806: Optimize the CSR progress message and log when CSR not found [v4]

Erik Joelsson erikj at openjdk.org
Fri Jan 27 15:20:23 UTC 2023


On Fri, 27 Jan 2023 15:05:58 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix a problem
>
> bots/common/src/main/java/org/openjdk/skara/bots/common/BotUtils.java line 48:
> 
>> 46:         if(confFile == null){
>> 47:             return Optional.empty();
>> 48:         }
> 
> Suggestion:
> 
>         if (confFile == null) {
>             return Optional.empty();
>         }

If you fix this formatting, then this is as good as it gets now. I'm not happy with the state of CheckRun, but at least this version should work as we want it without doing excessive extra work.

-------------

PR: https://git.openjdk.org/skara/pull/1463


More information about the skara-dev mailing list