RFR: 1925: When archiving a comment, mlbridgeBot would strip everything after the first command

Zhao Song zsong at openjdk.org
Fri Jun 2 16:10:43 UTC 2023

On Fri, 2 Jun 2023 15:06:14 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java line 143:
>>> 141:     }
>>> 142: 
>>> 143:     private boolean ignoreComment(HostUser author, String body, ZonedDateTime createdTime, ZonedDateTime lastDraftTime, boolean isComment) {
>> Introduced argument `isComment` to this method because I think in any case, no review should be ignored. But according to the previous logic, if a review whose body only contains command, the review would be ignored.
> I'm not sure about this. We already send email when someone approves a PR. I don't think we need to send emails with an empty review.

According to the previous logic, for example, if we approve a PR and the review body only contains command like "/reviewers 2", then this review will be ignored. This issue is what I want to resolve.

But now I also think something in my logic is wrong.


PR Review Comment: https://git.openjdk.org/skara/pull/1524#discussion_r1214565398

More information about the skara-dev mailing list