RFR: 1925: When archiving a comment, mlbridgeBot would strip everything after the first command
Erik Joelsson
erikj at openjdk.org
Fri Jun 2 17:11:19 UTC 2023
On Fri, 2 Jun 2023 16:40:46 GMT, Zhao Song <zsong at openjdk.org> wrote:
>> See this PR that I reviewed this morning: https://github.com/openjdk/jdk/pull/14261
>>
>> I didn't put any text in the review comment/body, but we still had this email sent: https://mail.openjdk.org/pipermail/build-dev/2023-June/039655.html
>
> Yes, empty body is good. But if and only if the review body only contains command, it will be ignored.
>
> Just like when you are approving the pr, you put "/reviewers 2"(or any other command) in the review body.
Ah, that's pretty bad, but I see what you mean now after having studied the code.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1524#discussion_r1214620450
More information about the skara-dev
mailing list