RFR: 1939: Make work item scheduling more resilient against failures

Kevin Rushforth kcr at openjdk.org
Fri Jun 9 23:14:15 UTC 2023

On Fri, 9 Jun 2023 21:49:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> When the BotRunner calls getPeriodicItems, any failure will terminate the whole loop. This means that one misconfigured repository, or problem with the forge, can prevent all other repos from being processed. I think it would be a good idea to keep trying each bot instance in the list even if some of them fail.
> This patch moves the catch clauses inside the loop. I'm also moving some logging and metrics gathering into a finally block.

Looks good.

Title should be "SKARA-1939".


Marked as reviewed by kcr (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1529#pullrequestreview-1473105899
PR Comment: https://git.openjdk.org/skara/pull/1529#issuecomment-1585175848

More information about the skara-dev mailing list