RFR: 1937: Re-evaulate all PRs when .jcheck/conf changes [v2]

Zhao Song zsong at openjdk.org
Wed Jun 14 15:56:13 UTC 2023

On Wed, 14 Jun 2023 14:19:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   update
> jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java line 158:
>> 156:     public static JCheckConfiguration parse(List<String> lines) {
>> 157:         var ini = INI.parse(lines);
>> 158:         var rawConf = String.join("", lines);
> This isn't actually the raw conf anymore, since it's been split by lines and then put together, but the original line breaks are lost. If we are calling this the "rawConf" then we should at least put `\n` back in there. Alternatively, we could store just a hash of the lines to make it clear that it can't be used to compare to another raw source of .jcheck/conf in the future.
> I think just putting linebreaks in is enough for now.

Will add the line breaks back. Thanks!


PR Review Comment: https://git.openjdk.org/skara/pull/1531#discussion_r1229846246

More information about the skara-dev mailing list