RFR: 1937: Re-evaulate all PRs when .jcheck/conf changes [v4]

Zhao Song zsong at openjdk.org
Wed Jun 14 18:03:56 UTC 2023

On Wed, 14 Jun 2023 16:09:33 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> As Erik said in the issue: "When we bump the version in .jcheck/conf from N to N+1 in the jdk master branch, PRs with CSRs are often not updated to reflect this."
>> This root cause of this is that changing of .jcheck/conf in target ref of the pr will not be able to trigger checkWorkItem for this pr.
>> In this patch,
>> 1. The prBot will monitor the changes to the .jcheck/conf file in any branch(except for PR branches).
>> 2. If the prBot detects an update to the .jcheck/conf file in a branch, it will trigger a checkWorkItem for all open PRs whose target ref is the branch where the .jcheck/conf file was updated.
>> 3. To solve the problem related with bot restarting, the contents of the .jcheck/conf file in the target branch of a PR will be included in the metadata hash.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   add line breaks back

Thanks for the review!


PR Comment: https://git.openjdk.org/skara/pull/1531#issuecomment-1591747661

More information about the skara-dev mailing list