RFR: 1554: Fold JEPBot into PR bot [v2]

Erik Joelsson erikj at openjdk.org
Tue Jun 27 13:08:10 UTC 2023

On Mon, 26 Jun 2023 22:25:46 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>   Remove jep module
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 330:
>> 328: 
>> 329:         var issueProject = issueProject();
>> 330:         if (issueProject != null) {
> Do we still need to check `issueProject ` here?

I'm not completely sure, but if we don't, there is a risk that we change behavior when a bot is configured without an issue tracker/project. It would be a good followup to really investigate if that should be a valid configuration and how that is supposed to work.


PR Review Comment: https://git.openjdk.org/skara/pull/1535#discussion_r1243698575

More information about the skara-dev mailing list