RFR: 755: Anything starting with a "/" is treated as a command [v2]

[Vijay Kulkarni]

On Tue, 28 Feb 2023 21:28:18 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Vijay Kulkarni has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   755:unified the regex for archive and execution command. Bot should react to invalid sakra commands
>
> bots/mlbridge/build.gradle line 50:
> 
>> 48:     implementation project(':metrics')
>> 49:     implementation project(':bots:common')
>> 50:     implementation project(path: ':jbs')
> 
> What does the `path:` prefix mean here? If it's not significant, better stay with the same pattern as the other dependencies.

Yes sure, I removed it to be consistent.

> bots/mlbridge/src/main/java/module-info.java line 35:
> 
>> 33:     requires org.openjdk.skara.network;
>> 34:     requires org.openjdk.skara.version;
>> 35:     requires org.openjdk.skara.jbs;
> 
> Do we really require jbs now?

I tried to remove it but got an error while running the test cases. I tried to add jbs as a test gradle dependency but it still complained during compiling code before running the tests.
So I guess, it is needed along with the common module. Hence I did not make any changes.

Here is the error message if removed.
`> Task :bots:mlbridge:compileJava FAILED
error: module not found: org.openjdk.skara.jbs
1 error`

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommitCommandWorkItem.java line 118:
> 
>> 116:                     `/{0}` is not a recognized Skara PR command, so it was ignored and treated like an ordinary comment.
>> 117:                     If you intended to issue a Skara command, use `/help` in a comment to see a complete list of Skara commands.
>> 118:                     """, command.name()));
> 
> Since we are keeping the mail filtering rules the same as command execution, I don't think we should change this message.

Sure, I reverted this change.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCommandWorkItem.java line 172:
> 
>> 170:                     `/{0}` is not a recognized Skara PR command, so it was ignored and treated like an ordinary comment
>> 171:                     If you intended to issue a Skara command, use `/help` in a comment to see a complete list of Skara commands.
>> 172:                     """, command.name()));
> 
> Same here, keep the message as is.

Sure, I reverted this change.

-------------

PR: https://git.openjdk.org/skara/pull/1479