RFR: 1824: /reviewers N should remove ready status for clean backports

Erik Joelsson erikj at openjdk.org
Tue Mar 14 17:18:02 UTC 2023

On Mon, 13 Mar 2023 23:08:53 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, If a user issues /reviewers command in a clean backport, the reviewers requirement will not be displayed in the pr body and it won't be an integration blocker.
> In this patch, after user issued /reviewers command, the reviewrs check for clean backport will be enabled. And if the Reviewers check requirements in the jcheck conf are stricter than the user's requirements, the bot will enforce the stricter requirements

We will likely get a followup request to be able to revert `/reviewers X` in a clean backport. Implementing that seems less straight forward, so I'm happy to leave that for later.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 146:

> 144:         if (pr.labelNames().contains("clean") && pr.labelNames().contains("backport")) {
> 145:             reply.println("Warning: The /reviewers command is used in a clean backport, it will enable reviewers check for this pr. " +
> 146:                     "If the reviewers check requirements in the jcheck conf are stricter than your requirements, the bot will enforce the stricter requirements.");


            reply.println("Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.");

I don't think we need to point out the application of stricter requirements in the reply. It's enough to document this on the wiki. I see I asked for it in the bug, but thinking on this more, the /reviewers command has never been able to reduce reviewer requirements from the minimum specified in .jcheck/conf.


PR: https://git.openjdk.org/skara/pull/1482

More information about the skara-dev mailing list