RFR: 1813: URLs printed by Skara should have ".git" at the end of the repo name [v6]
Zhao Song
zsong at openjdk.org
Tue Mar 14 17:45:24 UTC 2023
On Fri, 10 Feb 2023 14:06:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Looks good. The name `remoteUrl` doesn't seem very good, but with the comment, it is OK.
>
>> Looks good. The name `remoteUrl` doesn't seem very good, but with the comment, it is OK.
>
> I agree, it's hard to come up with a good name for this. Ideally I think this one should be just `url` and the existing `url` should be renamed something like `authenticatedUrl`.
@erikj79 Thank you very much for reviewing this big patch and identifying some issues!
-------------
PR: https://git.openjdk.org/skara/pull/1467
More information about the skara-dev
mailing list