RFR: 1840: A test failed due to the combination of SKARA-1823 and SKARA-755

Guoxiong Li gli at openjdk.org
Wed Mar 15 09:28:44 UTC 2023

On Tue, 14 Mar 2023 16:28:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

> This patch fixes MailingListBridgeBotTests::simpleArchive.

This patch looks good.

But when reading the code of this test case `MailingListBridgeBotTests::simpleArchive`, I notice the following code is wrong. ` pr.addLabel("rfr");` should be adjusted to ` pr.removeLabel("rfr");`. It is good to fix this little bug in this patch. What do you think?

// the line 279:
            // Remove the rfr flag and post another comment
            pr.addComment("@" + pr.author().username() +" This is another comment");


Marked as reviewed by gli (Committer).

PR: https://git.openjdk.org/skara/pull/1483

More information about the skara-dev mailing list