RFR: 1828: RFR emails still be sent when PR is in draft state

Erik Joelsson erikj at openjdk.org
Wed Mar 15 14:18:24 UTC 2023

On Wed, 15 Mar 2023 13:50:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> This patch blocks the RFR email when new commits are pushed to a draft PR. And the test case is added. too.
> But it doesn't solve the synchronization problem that Erik mentioned in [PR-1469](https://github.com/openjdk/skara/pull/1469#issuecomment-1425916242). Because the bot only generates one email one time regradless of the number of the commits.
> Thanks for the review.
> Best Regards,
> -- Guoxiong

I think this is fine. Perfect synchronization on commit emails isn't as important as for comments.


Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.org/skara/pull/1484

More information about the skara-dev mailing list