RFR: 1828: RFR emails still be sent when PR is in draft state [v2]
Zhao Song
zsong at openjdk.org
Wed Mar 15 18:11:39 UTC 2023
On Wed, 15 Mar 2023 14:36:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch blocks the RFR email when new commits are pushed to a draft PR. And the test case is added. too.
>>
>> But it doesn't solve the synchronization problem that Erik mentioned in [PR-1469](https://github.com/openjdk/skara/pull/1469#issuecomment-1425916242). Because the bot only generates one email one time regradless of the number of the commits.
>>
>> Thanks for the review.
>>
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into SKARA-1828
> - SKARA-1828
It's strange that mlbridge bot bridged emails that generated by itself. Filed [SKARA-1843](https://bugs.openjdk.org/browse/SKARA-1843)
-------------
PR Comment: https://git.openjdk.org/skara/pull/1484#issuecomment-1470513955
More information about the skara-dev
mailing list