RFR: 1843: mlbridge bot bridge emails generated by itself.

Guoxiong Li gli at openjdk.org
Thu Mar 16 13:48:39 UTC 2023


On Thu, 16 Mar 2023 05:20:54 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch filters both `github.com` (by `authenticatedUrl()`) and `git.openjdk.com` (by `url()`) in `MailingListArchiveReaderBot::inspect` to avoid the bot posting the unnecessary comments to the PRs. Please see SKARA-1843 [1] for more information.
> 
> But I can't write a test case for it now, because the current URLs of the repositories in test code are fake and their host are empty, which means both `pr.repository().url().getHost()` and `pr.repository().authenticatedUrl().getHost()` always return `null`.
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong
> 
> [1] https://bugs.openjdk.org/browse/SKARA-1843

> _Mailing list message from [Guoxiong Li](mailto:lgxbslgx at gmail.com) on [skara-dev](mailto:skara-dev at mail.openjdk.org):_
> 
> test mlbridge again -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/skara-dev/attachments/20230316/5aae3b54/attachment.htm>

This comment is posted successfully now. Is it done automatically? Or the bot is restarted, then this comment is posted?

-------------

PR Comment: https://git.openjdk.org/skara/pull/1485#issuecomment-1471990106


More information about the skara-dev mailing list