RFR: 1843: mlbridge bot bridge emails generated by itself. [v2]

Guoxiong Li gli at openjdk.org
Thu Mar 16 23:12:56 UTC 2023

> Hi all,
> This patch filters both `github.com` (by `authenticatedUrl()`) and `git.openjdk.com` (by `url()`) in `MailingListArchiveReaderBot::inspect` to avoid the bot posting the unnecessary comments to the PRs. Please see SKARA-1843 [1] for more information.
> But I can't write a test case for it now, because the current URLs of the repositories in test code are fake and their host are empty, which means both `pr.repository().url().getHost()` and `pr.repository().authenticatedUrl().getHost()` always return `null`.
> Thanks for the review.
> Best Regards,
> -- Guoxiong
> [1] https://bugs.openjdk.org/browse/SKARA-1843

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Change 'url' to 'authenticatedUrl'


  - all: https://git.openjdk.org/skara/pull/1485/files
  - new: https://git.openjdk.org/skara/pull/1485/files/b9fa0ec7..01cba348

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1485&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1485&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/skara/pull/1485.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1485/head:pull/1485

PR: https://git.openjdk.org/skara/pull/1485

More information about the skara-dev mailing list