RFR: 1843: mlbridge bot bridges emails generated by itself [v3]
Zhao Song
zsong at openjdk.org
Fri Mar 17 13:44:41 UTC 2023
On Fri, 17 Mar 2023 13:19:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Yes, but it's only the Skara project, so I was ok with living with it. But sure, we can keep the double filter if we add the following comment.
>> Suggestion:
>>
>> // Filter on both original, and any pattern replaced, host for now as we have polluted
>> // data in the Skara project mail archives. We should revert this to just authenticatedUrl
>> // eventually.
>> var bridgeIdStr = "^[^.]+\.[^.]+@(?:" + pr.repository().url().getHost() + "|" + pr.repository().authenticatedUrl().getHost() + ")$";
>> var bridgeIdPattern = Pattern.compile(bridgeIdStr);
>
>> Yes, but it's only the Skara project, so I was ok with living with it.
>
> After thinking more, I am OK with it too. It can also verify and confirm my thought about the hosts in this patch.
Another option for us is that we use double filter right now and after 14 days, we revert it back to only filter `authenticatedUrl()`. In this way, the polluted Skara emails wouldn't be bridged.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1485#discussion_r1140254977
More information about the skara-dev
mailing list