Integrated: 1843: mlbridge bot bridges emails generated by itself

Guoxiong Li gli at openjdk.org
Fri Mar 17 14:25:36 UTC 2023


On Thu, 16 Mar 2023 05:20:54 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch filters both `github.com` (by `authenticatedUrl()`) and `git.openjdk.com` (by `url()`) in `MailingListArchiveReaderBot::inspect` to avoid the bot posting the unnecessary comments to the PRs. Please see SKARA-1843 [1] for more information.
> 
> But I can't write a test case for it now, because the current URLs of the repositories in test code are fake and their host are empty, which means both `pr.repository().url().getHost()` and `pr.repository().authenticatedUrl().getHost()` always return `null`.
> 
> Thanks for the review.
> 
> Best Regards,
> -- Guoxiong
> 
> [1] https://bugs.openjdk.org/browse/SKARA-1843

This pull request has now been integrated.

Changeset: 0853677a
Author:    Guoxiong Li <gli at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/0853677abeb6d22580b3f4d0b0bfe03b4736630e
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

1843: mlbridge bot bridges emails generated by itself

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1485


More information about the skara-dev mailing list