RFR: 1830: Support wildcard branch protection with prbranches

Zhao Song zsong at openjdk.org
Mon Mar 20 22:04:01 UTC 2023

On Mon, 20 Mar 2023 21:56:22 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In this patch, notifyBot would add wildcard branch protection for the repo, and when the bot tries to delete the pr/* branch, it will temporarily remove wildcard branch protection.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 67:

> 65:         if (protectBranches) {
> 66:             log.info("Removing branch protection for " + branch);
> 67:             pr.repository().unprotectBranchPattern(branch);

We still need this because it's possible that we have some pr branch protected before we deploy this patch.


PR Review Comment: https://git.openjdk.org/skara/pull/1489#discussion_r1142717306

More information about the skara-dev mailing list