RFR: 1827: Better handling of Error [v2]

Erik Joelsson erikj at openjdk.org
Wed Mar 22 20:37:23 UTC 2023


On Wed, 22 Mar 2023 20:28:03 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve log message
>
> bot/src/main/java/org/openjdk/skara/bot/BotRunner.java line 236:
> 
>> 234:                 } catch (Error e) {
>> 235:                     EXCEPTIONS_COUNTER.labels(item.botName(), item.workItemName(), e.getClass().getName()).inc();
>> 236:                     log.log(Level.SEVERE, "Error thrown during item execution: " + e.getMessage(), e);
> 
> Maybe we could also log `item` in the message.

Right yes, that's a good idea.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1490#discussion_r1145377556


More information about the skara-dev mailing list