RFR: 1851: Fold CSR bot into PR bot
Zhao Song
zsong at openjdk.org
Mon Mar 27 23:13:53 UTC 2023
On Mon, 27 Mar 2023 22:33:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> In this patch, the whole csr bot module is removed.
>>
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>>
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1293:
>
>> 1291: }
>> 1292:
>> 1293: var versionOpt = BotUtils.getVersion(pr);
>
> Can we reuse version from line 1167?
Yes, we can.
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1149870838
More information about the skara-dev
mailing list